Repository navigation
[SDK-705] IterablePushRegistrationTask as Runnable instead of AsyncTask - #1093
Conversation
696e808 to
160504f
Compare
|
Stack review update after the rebase:
Check, BCIT, changelog, Java analysis, and the main build job passed. I have rerun the two failed jobs after confirming their failures were the external notification-image assertion and one instrumentation response timeout. Ready for another review. |
|
Rerun follow-up: the unit job now fails only on the repository-wide external IterableNotificationTest.testNotificationImage assertion. The instrumentation rerun reproduced the lower-stack AsyncTask response timeout in IterableApiResponseTest; that suite passes on SDK-706 once the deep-link lane is separated and passes on SDK-707 after request AsyncTask is removed. The push ordering coverage and BCIT remain green. |
|
@rtlsilva SDK-705 is ready for re-review in 8d7e9e3. The ordering concern is now handled across the complete push flow: registration and disable submissions, HTTP work, 5xx retries, and JWT retries remain on the SDK-owned serial push lane, while newer actions invalidate stale retries. General online requests are restored to their original thread-pool behavior, and push callbacks remain on main. The previous CodeQL findings were caused by newly added deprecated AsyncTask calls; those additions are gone from the final diff. Focused behavior tests, UI unit tests, static checks, root consumer tests, and Android-test compilation pass. CI is now running on the updated commit. |
8d7e9e3 to
50030e0
Compare
Summary
Jira: SDK-705
Replaces push registration AsyncTask orchestration with SDK-owned executors while preserving production behavior and rapid login/logout ordering.
Behavior
Compatibility
Verification