Repository navigation
build: move the build definition to Atom 5 (Tex) - #37
Merged
Merged
Conversation
Port _atom to the typed StructuredText expression API and reference Atom 5.0.0-rc.5 and Invex.RepoUtils.Atom.Module 3.0.0-rc.5. The regenerated Build.yml only changes two equivalent if: lines. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UBhDUQU8aoPYyyfUXRi1ct
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused migration preserves workflow behavior, and no blocking issues were identified.
No open issues 🎉
What changed in this PR
Migrates the build tooling to the Atom 5 release candidate without changing shipped packages.
Changes:
- Updates Atom and RepoUtils module dependencies.
- Replaces legacy expression helpers with
Texand adapts matrix values. - Regenerates two workflow conditions with equivalent negation syntax.
| File | Description |
|---|---|
.github/workflows/Build.yml |
Updates two release-only conditions without changing behavior. |
_atom/IBuild.cs |
Migrates expressions and matrix values to Atom 5 syntax. |
_atom/_atom.csproj |
Updates build-tool dependencies to release candidates. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: the build (
_atom) used Atom 4.2 and RepoUtils 2.0, with conditions written through the oldTextExpressionshelpers.After: the build uses Atom 5.0.0-rc.5 and Invex.RepoUtils.Atom.Module 3.0.0-rc.5, with conditions written with
Tex. The regenerated Build.yml only changes twoif:lines fromcontains(...) == falseto the equivalent${{ !contains(...) }}. Shipped packages are unchanged.This trials the Atom 5 release candidate before Atom 5.0 goes stable; the references move to the stable versions afterwards.
How: ported
_atom/IBuild.cstoTex(and a collection expression for matrix values), bumped the Atom and RepoUtils module references in_atom/_atom.csproj, and regenerated the workflow. Builds locally; two cancellation tests in ProcessRunnerTests fail in the sandbox, identically on main.Generated by Claude Code