Repository navigation
Fix double node restart in dynamic block production test - #3762
Merged
Merged
Conversation
Stop all nodes before updating the Supervisor configuration, then start the node group without interrupting auto-started processes. Keep the startup delay and remove the caller's redundant restart. Use the existing service wrappers and leave restart_all_nodes unchanged. Lint passed; the live E2E test was not rerun.
Remove reload_supervisor_config now that dynamic block production uses the stop, update, and start service wrappers directly. No callers remain. Lint passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reload_supervisor_config()helper.restart_all_nodes()unchanged.This avoids interrupting nodes during startup while ensuring all nodes restart together, as required on local testnets.