Repository navigation
fix(cluster): respin on pytest outcomes too - #3745
Merged
Merged
Conversation
`respin_on_failure` caught only `Exception`, so `pytest.skip`, `pytest.xfail` and `pytest.fail` raised inside the guard (directly or from helpers like `blockers.GH.finish_test`) left the changed state for the following tests. E.g. `test_committee_min_size` xfailing on ledger#4204 handed over the instance with resigned CC members. Catch `BaseException` except `KeyboardInterrupt`, drop the now redundant `set_needs_respin()` calls in the Leios quorum test and document the behavior in agent docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
respin_on_failurecaught onlyException, sopytest.skip,pytest.xfailandpytest.failraised inside the guard (directly or from helpers likeblockers.GH.finish_test) left the changed state for the following tests. E.g.test_committee_min_sizexfailing on ledger#4204 handed over the instance with resigned CC members.Catch
BaseExceptionexceptKeyboardInterrupt, drop the now redundantset_needs_respin()calls in the Leios quorum test and document the behavior in agent docs.