Repository navigation
fix(tests): mark cluster pools used by tests as in use - #3737
Merged
Merged
Conversation
Tests that lock a pool can retire it and register it again. Tests that depend on a cluster pool must mark it as "in use", so the pool cannot be retired while they run. - test_pool_registration_used_vrf_key: mark the first cluster pool as "in use". While the pool is retired, its VRF key could be registered by the test's pool, and the re-registration of the retired pool would then fail. - test_unstable_stake_distribution: take a pool marked as "in use" instead of a hardcoded one. - test_pool_vote_delegation: make sure the "all pools" and the single pool stake distribution queries happen in the same epoch. - Leios EB tests: mark all cluster pools as "in use", as the tests rely on every pool being on the voting committee. Mark also the performance as "in use" for the certified EB test, so tests generating heavy load don't take the block space.
mkoura
requested
a balanced review from Copilot
and removed request for
saratomaz
October 5, 2026 15:23
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The resource fixtures correctly prevent conflicting pool operations, and no unresolved issues were found.
Review effort: Balanced
Findings: None
What changed in this PR
Prevents concurrent tests from retiring or overloading pools required by active tests.
Changes:
- Marks required pools and performance capacity as in use.
- Selects a protected pool for stake-distribution testing.
- Keeps related stake-distribution queries within one epoch.
| File | Description |
|---|---|
test_leios_blocks.py |
Protects Leios pools and performance capacity. |
test_pools.py |
Protects pool1 and synchronizes distribution queries. |
test_blocks.py |
Uses a pool marked as in use. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests that lock a pool can retire it and register it again. Tests that depend on a cluster pool must mark it as "in use", so the pool cannot be retired while they run.