Repository navigation
Hold the collector off around the presence reader's timed windows - #549
Merged
Merged
Conversation
The quality run on the 1.2.0 release PR failed twice in a row on Ubuntu 3.14, at the first ready() of test_reader_loss_does_not_block_worker_owned_release_only_ack_cleanup. The reader must answer within 0.25 s. Under coverage and gdb, late in the suite, a whole-heap collection takes longer than that, and the fixed test order puts it in the same place on every run. The fixture now collects first and disables the collector for each test, and always re-enables it. The product deadline is unchanged.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 4 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The quality run on the 1.2.0 release PR (#548) failed on Ubuntu 3.14 twice, in the first attempt and its rerun, on the same test and in the same place: the first
ready()oftest_reader_loss_does_not_block_worker_owned_release_only_ack_cleanupraisedphysical presence reader deadline exhausted. All other 17,546 tests, and all eight other squares, passed.ready()must answer within 0.25 s. The same commit passed Dev CI's Ubuntu 3.14 square. The quality job adds onlycoverage run, and on Linux both jobs run under gdb.harnessfixture collects once, disables the collector for the test and always re-enables it. The product deadline is unchanged: a collection pause in production still fails closed.The quality run on #548 checks the fix. If the cause is something else, it fails again in the same place.