Repository navigation
Wait for the presence server to retire its source after a refused client - #543
Merged
Merged
Conversation
The server drops the accepted connection and then retires its source. The test checked for the retirement as soon as the client saw the close, and on the release PR's Windows 3.13 runner it had not landed yet. It now waits up to five seconds for both the source close and the failed status.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_failed_client_thread_start_retires_the_accepted_connectionfailed on the release PR (#538), on the Windows 3.13 runner. The source had not closed yet: the recorded events were['reserve', 'construct', 'start'].Cause. The server drops the accepted connection first and retires its source after that. The test checked for the retirement as soon as the client saw the close, so on a slow runner it ran ahead of the retirement.
Change. The test now waits up to five seconds for the source close and the failed status. It then asserts each one separately.