Skip to content

Wait until rules are imported to check if formatters exist - #578

Open
clayote wants to merge 1 commit into
Instagram:mainfrom
clayote:format-config
Open

clayote wants to merge 1 commit into
Instagram:mainfrom
clayote:format-config

Conversation

@clayote

@clayote clayote commented Oct 10, 2026 •

Copy link
Copy Markdown

Summary

This PR defers checking that the configured formatter exists until after the rules have been imported.
Users can now subclass fixit.Formatter in the same module as their Fixit rules,
rather than having to patch Fixit to use any in-house formatter they have.

Fixes #577.

Test Plan

I ran Fixit with the formatter and configuration in #577. It worked.

I ran Fixit with a nonexistent formatter, and it exited with ConfigError before running any rules.

@meta-cla

meta-cla Bot commented Oct 10, 2026

Copy link
Copy Markdown

Hi @clayote!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@clayote
clayote requested a review from amyreese as a code owner October 10, 2026 18:35
@meta-cla

meta-cla Bot commented Oct 10, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Formatters are not imported from enabled rules

1 participant