Repository navigation
Conversation
|
Hi @clayote! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary
This PR defers checking that the configured formatter exists until after the rules have been imported.
Users can now subclass
fixit.Formatterin the same module as their Fixit rules,rather than having to patch Fixit to use any in-house formatter they have.
Fixes #577.
Test Plan
I ran Fixit with the formatter and configuration in #577. It worked.
I ran Fixit with a nonexistent formatter, and it exited with
ConfigErrorbefore running any rules.