Skip to content

UID2-7920: Resolve sample image vulnerabilities - #219

Merged
swibi-ttd merged 1 commit into
mainfrom
swi-UID2-7920-resolve-vulnerabilities
Sep 21, 2026
Merged

swibi-ttd merged 1 commit into
mainfrom
swi-UID2-7920-resolve-vulnerabilities

Conversation

@swibi-ttd

Copy link
Copy Markdown
Contributor

Summary

  • move all seven Node sample images from Node 20 / Alpine 3.18 to Node 24.21.0 / Alpine 3.24
  • install production dependencies only, remove npm and npx from runtime images, run as the non-root node user, and start with node directly
  • update brace-expansion to 5.0.9 and remove Trivy exceptions that no longer suppress current findings

This prepares the repository for the all-image scanning introduced by #216.

Vulnerability resolution

The HIGH/CRITICAL findings came from the EOL Alpine 3.18 base, npm and its bundled dependencies in the runtime images, dev-only dependencies installed into server images, and brace-expansion 5.0.8. Each has been fixed rather than ignored.

MEDIUM/LOW dependency findings remain outside this ticket scope.

Verification

  • built all 14 Dockerfile/context combinations from the UID2-7877: Scan all sample Docker images for vulnerabilities #216 matrix with fresh base images
  • Trivy filesystem scan: zero HIGH/CRITICAL findings without vulnerability exceptions
  • Trivy image scans: zero HIGH/CRITICAL findings in all 14 images
  • npm audit --omit=dev: zero HIGH/CRITICAL findings in all seven Node apps
  • both React production builds pass under Node 24
  • all seven Node images run as UID 1000 on Node 24.21.0, contain no npm or npx, and return HTTP 200 for /ops/healthcheck and /

Jira: https://thetradedesk.atlassian.net/browse/UID2-7920

Comment thread package.json Resolved
@swibi-ttd
swibi-ttd force-pushed the swi-UID2-7920-resolve-vulnerabilities branch from 93c69bc to 5034a19 Compare September 21, 2026 04:57
@swibi-ttd
swibi-ttd merged commit 2e5ed51 into main Sep 21, 2026
21 checks passed
@swibi-ttd
swibi-ttd deleted the swi-UID2-7920-resolve-vulnerabilities branch September 21, 2026 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants