Skip to content

Make MC info optional - #33

Merged
lubynets merged 6 commits into
HeavyIonAnalysis:masterfrom
AxelPuntke:json_config_impl
Sep 15, 2026
Merged

lubynets merged 6 commits into
HeavyIonAnalysis:masterfrom
AxelPuntke:json_config_impl

Conversation

@AxelPuntke

Copy link
Copy Markdown
Contributor

This pull requests adds a new config option which indicates if MC info is available. In case it is not, some mc-related computations will be omitted. This update is necessary to run PFSimple on the CBM Vertical Test Data which does not contain any MC information.

@lubynets lubynets left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AxelPuntke, thanks for the development!

  1. I left two small comments in the list of changes.
  2. Can you please run the clang-formatting locally? I don't know why, but the CI test passes, although your changes break the formatting requirements. When I have time, I can debug this issue systematically (or you are welcome to do this), but now the manual formatting will be fine.
  3. Do you have an idea why one of the two CI build crashes?

Comment thread at_interface/ConverterIn.cpp Outdated
Comment thread at_interface/ConverterOut.hpp Outdated
@AxelPuntke

Copy link
Copy Markdown
Contributor Author

Hi @AxelPuntke, thanks for the development!

1. I left two small comments in the list of changes.

2. Can you please run the clang-formatting locally? I don't know why, but the CI test passes, although your changes break the formatting requirements. When I have time, I can debug this issue systematically (or you are welcome to do this), but now the manual formatting will be fine.

3. Do you have an idea why one of the two CI build crashes?

Hi Olekssii,

  1. They have been addressed.
  2. Yes, I did it and applied the changes.
  3. I think it was some webserver which was not reachable (see the logs), now it works again.

@lubynets

Copy link
Copy Markdown
Collaborator

Hi @AxelPuntke, thanks for the development!

1. I left two small comments in the list of changes.

2. Can you please run the clang-formatting locally? I don't know why, but the CI test passes, although your changes break the formatting requirements. When I have time, I can debug this issue systematically (or you are welcome to do this), but now the manual formatting will be fine.

3. Do you have an idea why one of the two CI build crashes?

Hi Olekssii,

1. They have been addressed.

2. Yes, I did it and applied the changes.

3. I think it was some webserver which was not reachable (see the logs), now it works again.

Hi Axel, thanks for the fixes!

@lubynets
lubynets merged commit e7cd9c4 into HeavyIonAnalysis:master Sep 15, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants