Repository navigation
Make MC info optional - #33
Merged
Merged
Conversation
lubynets
requested changes
Sep 14, 2026
lubynets
left a comment
Collaborator
There was a problem hiding this comment.
Hi @AxelPuntke, thanks for the development!
- I left two small comments in the list of changes.
- Can you please run the clang-formatting locally? I don't know why, but the CI test passes, although your changes break the formatting requirements. When I have time, I can debug this issue systematically (or you are welcome to do this), but now the manual formatting will be fine.
- Do you have an idea why one of the two CI build crashes?
Contributor
Author
Hi Olekssii,
|
Collaborator
Hi Axel, thanks for the fixes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull requests adds a new config option which indicates if MC info is available. In case it is not, some mc-related computations will be omitted. This update is necessary to run PFSimple on the CBM Vertical Test Data which does not contain any MC information.