Skip to content

chore: protect enterprise staging - #24

Merged
setlin-hacktron merged 1 commit into
main-enterprisefrom
chore/protect-enterprise-staging
Oct 20, 2026
Merged

setlin-hacktron merged 1 commit into
main-enterprisefrom
chore/protect-enterprise-staging

Conversation

@setlin-hacktron

Copy link
Copy Markdown

Adds branch protection for enterprise staging. Right now it has none.

Once HacktronAI/enterprise#90 merges, every push to staging runs the staging-sync and converge Cloud Build jobs as enterprise-build-sa, which holds the vendor signing key and compute.admin. Hacktron finding HAC-FD-4116 on github-community-projects#90 was resolved as accepted risk on the condition that staging gets the same protection as main.

Matches the org-default main protection: 1 approving review, dismiss stale reviews, last-push approval, enforce admins, core can bypass. Two differences:

  • restrictions: null, so authors outside core (e.g. yhanyi) can merge their own approved PRs. The review is still required. Same setup as hacktron staging.
  • require_code_owner_reviews: false, because enterprise has no CODEOWNERS file.

main keeps the org default.

🤖 Generated with Claude Code

https://claude.ai/code/session_01REL3t1kJfB4tUVLfU6S22W

enterprise staging now drives the staging-sync and converge builds,
which run as the build identity holding the vendor signing key. Mirror
the org default main protection (1 review, stale dismissal, last-push
approval, enforce admins, core bypass). No push restrictions, so authors
outside core can merge their own approved PRs; no code-owner review,
since enterprise has no CODEOWNERS.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01REL3t1kJfB4tUVLfU6S22W
@hacktron-safe-settings

Copy link
Copy Markdown

🤖 Safe-Settings config changes detected:

Msg Plugin Repo Additions Deletions Modifications

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T01:06:00.648370Z 19522f7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@setlin-hacktron
setlin-hacktron merged commit 1734246 into main-enterprise Oct 20, 2026
8 checks passed
@setlin-hacktron
setlin-hacktron deleted the chore/protect-enterprise-staging branch October 20, 2026 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant