Repository navigation
chore: exclude bench-dv-cases from safe-settings - #22
Conversation
bench-dv-cases is a benchmark repo like hacktron-bench and the bench-dataset-* repos; its owner manages their own branch protection, which the org default would otherwise revert. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016mJu7Jg7YkTwh3Nxdcp4sg
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a61e7a63d6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| # Benchmark harness + datasets: owner manages their own branch protection. | ||
| - "hacktron-bench" | ||
| - "bench-dataset-*" | ||
| - "bench-dv-cases" |
There was a problem hiding this comment.
On a configuration-only Helm upgrade—for example, when an operator pins the image tag—the ConfigMap will receive this new exclusion but the Deployment pod template has no ConfigMap checksum and mounts the file using subPath (helm/safe-settings/templates/deployment.yaml:51-63), so the existing pod keeps its old mounted file. DeploymentConfig reads that file only during static initialization (lib/deploymentConfig.js:15-18), meaning safe-settings will continue managing bench-dv-cases until someone manually restarts the pod.
Useful? React with 👍 / 👎.
Summary
bench-dv-casestodeploymentConfig.restrictedRepos.excludein the Helm values, next to the other benchmark repos (chore: exclude benchmark repos from safe-settings #21).Same reason as #21: benchmark repo owner manages their own branch protection; the org default would revert manual edits. Explicit entry rather than a broader
bench-*glob to avoid catching unrelated future repos.Test plan
npx jest test/unit/lib/settings.test.js -t "Helm deployment values"passesHacktronAI/bench-dv-cases🤖 Generated with Claude Code
https://claude.ai/code/session_016mJu7Jg7YkTwh3Nxdcp4sg