Repository navigation
fix: check balance before recording a purchase, reject dotted event names, return 0 points for new users - #162
Merged
Merged
Conversation
…ames, return 0 points for new users
DaStormer
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was done
attend-event: checks the attendance limit and the balance first, and only saves anything after both pass.attend-event: points get saved in one step that also creates the points record if it's not there yet (upsert), so there's no separate insert anymore.attend-event: event names with a.or starting with$get a 400.points:auth_emailis optional again and falls back toemail.points: if someone has no points record yet, it returns 0 instead of a 404.update: check-in start time has a timezone now (10:30 AM Eastern), and the error messages show Eastern time.Why
$at the start as an operator, so a name like that gets saved in the wrong spot and the limit never gets checked.auth_email, so making it required would break points for every hacker until the new frontend is out.Merge this after or with the frontend PR (HackRU/frontendv2#368), since the old frontend still sends sponsor names with dots in them.