Conversation
The >=100 threshold counted distinct hostnames of the resource URL, so a resource used only on many subdomains of one site (for example $city.$vulnerable-group.com) passed the privacy gate. Count distinct sites (eTLD+1 of the embedding page) using the full Public Suffix List, including the private section that BigQuery's NET.PUBLIC_SUFFIX() skips. Add a script and a monthly workflow to keep the private rules current.
Member
Author
|
This is a follow-up to #324. |
Member
|
TIL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ≥100 threshold in
public_hash_listcounts distinct hostnames of the resource URL, so a font used only on 100$city.$vulnerable-group.comlanding pages passes, even though it identifies a single site, and any origin could then probe Cross-Origin Storage for its hash to infer that the user belongs to that group. This PR counts distinct sites (eTLD+1 of the embedding page) using the full Public Suffix List, including the private section that BigQuery'sNET.PUBLIC_SUFFIX()skips, soalice.github.ioandbob.github.iostill count as two sites, renamesnum_originstonum_sites, and adds a script plus a monthly workflow that keep the private suffix rules current. @max-ostapenko, could you please review?