Repository navigation
Send message using Enter on physical keyboard - #450
Open
RobertoTired wants to merge 3 commits into
Open
RobertoTired wants to merge 3 commits into
RobertoTired wants to merge 3 commits into
Conversation
Allow sending of message using Enter key on physical keyboard. A parameter toggle has been added to switch between 'Enter to send / Enter + Shift for multiline' and 'Enter for multiline / Ctrl + Enter to send'.
(sad...)
Author
|
Not sure how to fix the Instrumented tests (Android 17 x86_64) issue... I run ./gradlew :app:connectedDebugAndroidTest with a local emulator and I got no issue |
Member
|
It fails because CI emu has 320x640 screen with 160dpi. |
RankoR
suggested changes
Oct 28, 2026
Member
There was a problem hiding this comment.
Please also:
- Squash commits into a single commit
- Remove new localized strings for all languages except English and Russian.
Feature tests coverage is incomplete:
- MessageComposeBarInputTypeTest only tests with the setting off. Nothing covers setting on + Enter sends, setting on + Shift+Enter inserts a newline, or a soft-keyboard Enter not sending.
- AppSettingsRepositoryImplTest.kt makes
SEND_ON_ENTERreturn true, but never assertsresult.sendOnEnterEnabledand doesn't include that read in its verify block - setBooleanPref_writesEveryApplicationBooleanPreferenceKey covers five prefs and skips
SEND_ON_ENTER. - AppSettingsUiStateMapperImplTest only adds
sendOnEnterEnabled = false, which is the default, so the mapping isn't really checked.
| } | ||
| } | ||
|
|
||
| private fun EditText.setupKeyboardSendHandler(onImeSend: State<(() -> Unit)?>) { |
Member
There was a problem hiding this comment.
Enter from a soft keyboard counts as "physical keyboard" and sends the SMS. Reject events where event.flags and KeyEvent.FLAG_SOFT_KEYBOARD != 0, and add a test.
Member
There was a problem hiding this comment.
Also, holding Enter can send more than once. Add event.repeatCount == 0.
RankoR
reviewed
Oct 28, 2026
| keyCode == KeyEvent.KEYCODE_ENTER || keyCode == KeyEvent.KEYCODE_NUMPAD_ENTER | ||
| if (isPhysicalKeyboard && isEnterKey && event.action == KeyEvent.ACTION_DOWN) { | ||
| val ctx = view.context | ||
| val prefs = ctx.getSharedPreferences( |
Member
There was a problem hiding this comment.
View must not read shared preferences.
RankoR
reviewed
Oct 28, 2026
| <string name="in_conversation_sound_pref_title">In-conversation message sounds</string> | ||
| <string name="in_conversation_sound_pref_summary">Play a quiet sound for a message that arrives in the conversation you are viewing. Muted and snoozed conversations stay silent.</string> | ||
| <string name="send_on_enter_pref_title">Send on Enter on physical keyboard</string> | ||
| <string name="send_on_enter_pref_summary">Send a message when pressing Enter on a physical keyboard. Use Shift + Enter for a new line. Ctrl + Enter always send the message</string> |
Member
There was a problem hiding this comment.
Should be Ctrl + Enter always sends the message I think
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow sending of message using Enter key on physical keyboard. A parameter toggle has been added to switch between 'Enter to send / Enter + Shift for multiline' and 'Enter for multiline / Ctrl + Enter to send'.
Thanks