Repository navigation
Accept numpy scalars for text's angle, Pattern's pattern and binstats' quantile_value - #4962
Draft
tashakaggarwal wants to merge 1 commit into
Draft
tashakaggarwal wants to merge 1 commit into
tashakaggarwal wants to merge 1 commit into
Conversation
Member
|
Thanks for the PR. I agree that it's more flexible to accept numpy scalars, but I feel we should have a more general way to handle it. |
seisman
marked this pull request as draft
October 28, 2026 03:36
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Several places validate numeric input with
isinstance(x, int)/isinstance(x, (int, float)).NumPy integers (
np.int64,np.int32) andnp.float32are not instances ofint/float, sothey are handled inconsistently compared with the equivalent Python numbers:
Figure.text(angle=np.int64(30))silently ignores the angle (no error, no+a30in-F).This is the worst case because there is no feedback.
Pattern(np.int64(15))raisesGMTValueError: Invalid pattern number.binstats(statistic="quantile", quantile_value=np.int64(50))(ornp.float32) raisesGMTTypeError.This PR checks against
numbers.Real/numbers.Integralinstead, which NumPy scalars registerwith. Booleans are explicitly rejected for
Pattern.patternandbinstats(quantile_value), sinceTrueis anintin Python and previously producedPattern(True)->'p'(a pattern with nonumber).
Tests added for all three.