Repository navigation
Docs: Rewrite the plot -A documentation - #9284
Merged
Merged
Conversation
Explain how geographic points are connected: without -A along the shorter great circle arc (antipodal points cause an error), with -A by straight lines on the map that depend on -R and -J and are not split at the map edges. Also fix the 'gragraphic' typo. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
remkos
approved these changes
Oct 30, 2026
remkos
left a comment
remkos
left a comment
Contributor
There was a problem hiding this comment.
This is a very good improvement of the description. It is fully correct.
The history behind this was that @PaulWessel had introduced -A long time ago, which (if I remember well) did first longitude then latitude. I added the x|y because I needed it to be the other way around for some application. Clearly, the manual could have been much better and also all the cases better experimented with.
Good job!
Member
Author
|
Thanks @remkos! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explain better how
plot/plot3dshould connect geographic points.This describes the intended behavior, not the current one (e.g., the bug to be fixed in #9276).
After carefully reviewing the code and analyzing the different cases with Claude, I think this description explains well how it should work. It will be used as a guide for future changes to the code.
Since this defines how
-Ais meant to behave, please read it carefully before approving, and feel free to propose alternatives if you think a different behavior makes more sense.