Repository navigation
feat(network): Share the game network settings between LAN and online - #656
Open
tintinhamans wants to merge 17 commits into
Open
tintinhamans wants to merge 17 commits into
tintinhamans wants to merge 17 commits into
Conversation
…m::openArchiveFile() (TheSuperHackers#3376) (cherry picked from commit 86f2cab)
(cherry picked from commit 5db4f75)
…leSystem, Win32LocalFileSystem (TheSuperHackers#3374) (cherry picked from commit 3f3ed9f)
…ile::getFileInfo(), StdBIGFile::getFileInfo() (TheSuperHackers#3415) (cherry picked from commit b805c12)
…File (TheSuperHackers#3505) Both classes are identical apart from their name and contain no platform specific code. Nothing in them depends on the BIG format either: they open a file from an offset and a size inside the archive file. ArchiveFile takes over their functions and is no longer an abstract class. (cherry picked from commit 52a777a)
…ystem into BIGFileSystem (TheSuperHackers#3505) Both classes are identical apart from their name and go through the local file system for all file access. The one class that remains sits next to ArchiveFileSystem in Core/GameEngine. (cherry picked from commit e4b4d1e)
…e loadBigFilesFromDirectory (TheSuperHackers#3505) loadMods refers to BIG files, which nothing else in ArchiveFileSystem does. It becomes a virtual function that BIGFileSystem implements. loadBigFilesFromDirectory is renamed to loadArchiveFilesFromDirectory, because the base class is not tied to one archive format. (cherry picked from commit f299561)
tintinhamans
force-pushed
the
arctic/go/stack2/01-network-settings
branch
from
October 25, 2026 05:20
01be92d to
9a9d72d
Compare
…e Zero Hour archives (cherry picked from commit aaea4c1)
…only with verbose logging
tintinhamans
force-pushed
the
arctic/go/stack2/01-network-settings
branch
from
October 25, 2026 11:15
9a9d72d to
d767039
Compare
tintinhamans
force-pushed
the
arctic/go/stack2/01-network-settings
branch
from
October 25, 2026 12:53
d767039 to
70fac98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge after #646.
NGMPGame::launchGamewrote the run ahead settings from the service config straight into engine globals, so only an online match could set them and every new setting needed another block there.NetworkSettings(new, in Core) now holds the per-matchsendandinput_delaysettings.ConnectionManager::initfills it from compiled defaults, and in an online match from the service config, then sets the run ahead globals from it. LAN uses the same defaults as online. Later PRs add their keys to the same struct.The service config is now grouped (
connection,send,input_delay,lobby,telemetry) and only the grouped keys are read. A key the service sets is used, a missing key keeps its compiled default, values are clamped. The flat reader,use_default_config, the retail and custom profiles and theibra_*keys are gone, so only new clients connect. Renames includerelay_all_traffictoconnection.relay_only,ice_implementationtoconnection.ice_engine,enable_host_migrationtolobby.host_migration,do_probestotelemetry.screenshot_probesandframe_grouping_framestosend.frames_per_packet.Compiled defaults change:
lobby.host_migrationfalse (was true), screenshot size 960 x 600 (was 557 x 333), minimum run ahead 4 (was 6). Also fixesdeleteinstead ofdelete[]inFrameMetrics. No wire change.Tested: every tip builds x86 Release
z_generals.