Repository navigation
fix(lobby): Place lobby members by their slot and remove peers that left - #650
Closed
tintinhamans wants to merge 7 commits into
Closed
tintinhamans wants to merge 7 commits into
tintinhamans wants to merge 7 commits into
Conversation
…nections the server asked for
…its and the start check
…start until the roster is complete
Author
|
Folded into #625. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge after #625.
UpdateSlotsFromCurrentLobbyasked for the member at each slot position, so positions past the list got a default slot index999999that wrapped to 16959 in auint16_t, and members without a usable slot were skipped silently. A peer that closed cleanly also stayed in the mesh and logged[DISC] Recv Failedevery 5 s.Members are now placed by their own
SlotIndexand unclaimed slots are opened. A member without a valid slot keeps the previous roster and refetches the lobby, and match start waits until every human has a slot. The host's connectivity check no longer passes with no link to another human, and a peer that left cleanly is removed from the mesh.No wire or service change. Tested:
z_generalsbuilds, parser harness with badSlotIndexvalues. Not tested in a real lobby.