Skip to content

Report unsupported configuration fields - #83

Open
GaTTGeng wants to merge 4 commits into
masterfrom
feature/diagnose-compose-fields
Open

GaTTGeng wants to merge 4 commits into
masterfrom
feature/diagnose-compose-fields

Conversation

@GaTTGeng

@GaTTGeng GaTTGeng commented Oct 20, 2026 •

Copy link
Copy Markdown
Owner

What does this PR do?

  • Adds structured diagnostics for unknown, parsed-only, and partially applied configuration fields.
  • Normalizes scalar health checks to CMD-SHELL, reports unapplied build options and extra network attachments, and validates all direct Engine operations in strict mode.
  • Preserves overlay source provenance for escaped keys and ignores default-only resource definitions.
  • Verifies integration-test teardown removes networks carrying each test project's ownership label.
  • Reports multiple build platforms and duplicate target-port mappings before Engine operations, and treats service platform as a build fallback where applicable.
  • Diagnoses long-form service volumes and unretained build keys, avoids warnings for default zero resource values and dependency conditions that match readiness behavior, and attributes merged-map diagnostics to the contributing overlay.

Why is this change needed?

Configurations that parse successfully can still behave differently when fields are only partly applied. The diagnostics and strict checks make these gaps visible before Engine operations, while the teardown assertion catches project network leaks that can exhaust a local daemon's address pool.

How was this tested?

  • dotnet restore — passed.
  • dotnet build --configuration Release --no-restore — passed with 0 warnings.
  • Unit tests — passed on net8.0, net9.0, and net10.0 (275 each).
  • dotnet pack --configuration Release --no-build --no-restore --output artifacts/packages — passed.
  • Package README verification — passed for all 8 packages.
  • Rider InspectCode on changed C# files — 0 suggestion-level findings.
  • Full solution tests were run previously. Unit tests passed; Docker integration tests failed during network creation because the local daemon reported all predefined address pools have been fully subnetted. Integration test teardown now checks for remaining networks by the test project's label.

Checklist

  • Code follows the repository style.
  • Tests were added or updated for the behavior change.
  • Documentation was updated where needed.
  • CHANGELOG.md was updated.
  • No unrelated generated files, IDE metadata, packages, or secrets are included.
  • Build passed for the supported target frameworks.
  • Full solution test run passes. Docker integration tests are blocked by the daemon address-pool exhaustion described above; the full unit suite passes for all three target frameworks.

Issue #65 lists #22 and #23 as prerequisites; both remain open and should be resolved before merge.

Copilot AI balanced review requested due to automatic review settings October 20, 2026 09:18

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-26T01:24:01.559278Z 79283af Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9a313d3bf9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/ComposeSharp.Loader/ComposeFileLoader.cs Outdated
Comment thread src/ComposeSharp.Loader/ComposeFileLoader.cs Outdated
Comment thread src/ComposeSharp.Loader/ComposeFileLoader.cs
Comment thread src/ComposeSharp.Loader/ComposeFileLoader.cs Outdated
Comment thread src/ComposeSharp.Loader/ComposeFileLoader.cs Outdated
Comment thread src/ComposeSharp.Engine/ComposeService.cs
Comment thread src/ComposeSharp.Loader/ComposeFileLoader.cs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d8a62e2e77

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/ComposeSharp.Loader/ComposeFileLoader.cs
Comment thread src/ComposeSharp.Loader/ComposeFileLoader.cs Outdated
Comment thread src/ComposeSharp.Loader/ComposeFileLoader.cs Outdated
Comment thread src/ComposeSharp.Loader/ComposeFileLoader.cs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: caf18fb82f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/ComposeSharp.Loader/ComposeFileLoader.cs
Comment thread src/ComposeSharp.Loader/ComposeFileLoader.cs
Comment thread src/ComposeSharp.Loader/ComposeFileLoader.cs
Comment thread src/ComposeSharp.Loader/ComposeFileLoader.cs
Comment thread src/ComposeSharp.Loader/ComposeFileLoader.cs Outdated
Comment thread src/ComposeSharp.Loader/ComposeFileLoader.cs Outdated
@GaTTGeng

Copy link
Copy Markdown
Owner Author

@codex review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants