Repository navigation
fix: preserve on-failure restart retry counts - #82
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Preserves the retry limit in service-level
restart: on-failure:Nwhen creating Docker containers.on-failureandon-failure:0retain unlimited retries. Counts from 0 through 2147483647 are accepted; malformed, negative, signed, or overflowing suffixes produce source/service/property diagnostics during loading and are rejected by the Engine mapping as well.Adds focused loader and mapping boundary tests plus Docker container-inspection coverage. Updates model XML documentation, both READMEs, the compatibility matrix, roadmap, and CHANGELOG.
Why is this change needed?
The Engine previously discarded the retry suffix, allowing containers to restart beyond the configured limit.
Fixes #56
How was this tested?
Restore and Release build passed for .NET 8, 9, and 10 with zero warnings/errors.
All 762 unit tests passed across the three frameworks.
Full solution test run: 786 passed and 66 failed. The local Linux Docker Engine 29.8.2 is reachable through Windows named pipes, but its default address pools are exhausted; failures report
all predefined address pools have been fully subnetted, including the six new integration cases. No existing Docker resources were removed. Full daemon behavior requires the clean CI environment; Windows-container daemon coverage was not performed.Release pack and
VerifyPackageReadme.ps1passed (8 packages).Solution-context Rider command-line inspection of every changed C# file at Suggestion severity or higher reported no findings.
git diff --checkpassed.dotnet build ComposeSharp.sln --configuration Releasedotnet test ComposeSharp.sln --configuration Release(local daemon address-pool exhaustion; see above)Checklist
README.md/README.zh-CN.md/docs/*as applicable)CHANGELOG.md[Unreleased]updated for user-visible changes