Repository navigation
Conversation
Add a structured design and review skill for multi-step agent workflows, with state, gate, verification, and authority controls. Co-authored-by: OpenCode Agent <user@gsa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Origin and Design Rationale
This skill originated from a submitted workflow-design guide that collected practical lessons for operating complex, multi-step agent workflows. The guide was useful as a source of design principles, but it was too long and reference-oriented to load directly as a reusable agent skill.
This contribution converts those principles into a concise operational skill that tells an agent:
PASS,BLOCKED, orNEEDS-REVISION.The skill intentionally does not implement an orchestration platform, authorize actions, or claim that a workflow is safe to execute. It establishes a reviewable design package that a human and implementation team can use before execution.
The draft also resolves source-material issues that would not be suitable for a repository skill, including removing personal contact information and avoiding broken internal-reference conventions. It uses generic examples and repository-standard frontmatter, routing metadata, safety constraints, and behavioral test cases.
Content Type
Safety Checklist
prohibited_contentdefined in frontmatterQuality Checklist
make validatepassesexperimentalINDEX.yamlandCATALOG.mdregeneratedVerification Transcript
Passed:
make generatemake validatemake test(448 passed)make test-cases(77 passed, including 4 new cases)make generate-checkmake scan-shell(0 errors, 0 warnings)make validate-kitsmake test-kitspip-audit --skip-editablegit diff --checkKnown baseline exception:
make cireaches the Ruff pre-commit hook and fails on two intentional vulnerable-code fixtures in.agents/skills/secure-code-review/tests/fixtures/sample-code.py:S608(SQL injection) andS605(shell execution). This PR does not modify that fixture. All remaining CI phases that were run independently pass.Rollback
Revert commit
47897f8to remove the skill, test cases, and generated catalog entries.Security Impact
No authentication, authorization, runtime data-handling, or attack-surface changes. The skill improves workflow-planning controls by requiring explicit authority, deterministic verification, durable evidence, and a
BLOCKEDorNEEDS-REVISIONresult when approvals or constraints are missing.AI Assistance
This PR was drafted with OpenCode AI assistance. Human review is required before merge.