fix uefi build with rust 1.99 - #378
Merged
Merged
Conversation
Running clippy for the UEFI target found: - unused_variables: smartbattery_arg is only used without uefi feature - clippy::unnecessary_unwrap: unwrap() after checking is_ok() in --pd-addrs and --pd-ports - clippy::len_zero: args.len() == 0 instead of args.is_empty() - clippy::needless_range_loop: --rgbkbd indexed args with a range Signed-off-by: Daniel Schaefer <dhs@frame.work>
Since Rust 1.99 (LLVM 23), loops that search for a NUL u16, like in
uefi's CStr16::from_ptr, are turned into calls to wcslen. There's no
libc on UEFI and compiler_builtins doesn't provide it, so linking fails:
rust-lld: error: undefined symbol: wcslen
Provide our own implementation. It uses volatile reads, so LLVM can't
turn it into a call to itself.
Disabling the optimization with -C llvm-args=-disable-loop-idiom-wcslen
also works, but older toolchains reject that unknown argument.
Signed-off-by: Daniel Schaefer <dhs@frame.work>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.