windows: Statically link C++ runtime - #377
Merged
Merged
Conversation
Since smartmontools was added, the release binary depends on MSVCP140.dll, which is not present on a clean Windows install. cc compiles C/C++ dependencies with /MD unless the crt-static target feature is set, which links the C++ STL dynamically. static_vcruntime only changes linker arguments, so it doesn't help there. Set +crt-static for MSVC targets and add a CI check that the binary doesn't depend on the VC++ redistributable. Signed-off-by: Daniel Schaefer <dhs@frame.work>
Member
Author
|
uefi error is unrelated to this change. comes from a new rust version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since smartmontools was added, the release binary depends on MSVCP140.dll, which is not present on a clean Windows install.
cc compiles C/C++ dependencies with /MD unless the crt-static target feature is set, which links the C++ STL dynamically. static_vcruntime only changes linker arguments, so it doesn't help there.
Set +crt-static for MSVC targets and add a CI check that the binary doesn't depend on the VC++ redistributable.