Repository navigation
fix: represent absent and empty creator and suffix explicitly - #1009
Draft
marcpaterno wants to merge 1 commit into
Draft
marcpaterno wants to merge 1 commit into
marcpaterno wants to merge 1 commit into
Conversation
- Model an unqualified creator's plugin and an empty suffix as explicit empty values instead of invalid empty identifiers. - Make a product specification's creator optional; provider construction now requires a present creator. - Reject empty algorithm names, empty plugin components, and an empty configured module_label instead of accepting them silently. - Rename the default source creator from "[Source]" to "phlex_source", which is a valid name under the new parser. - Return borrowed string views from handle creator() and suffix() accessors. - Add tests for parsing, equality/hashing, exact product lookup, provider construction, and handle views.
marcpaterno
added this pull request to stack #1004
October 23, 2026 22:34
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
explicit empty values instead of invalid empty identifiers.
construction now requires a present creator.
configured module_label instead of accepting them silently.
which is a valid name under the new parser.
accessors.
provider construction, and handle views.
Stack created with GitHub Stacks CLI • Give Feedback 💬