Repository navigation
Sn streaming 3.3.0 - #4
Merged
Merged
Conversation
The CppWriter lib test regenerates C++ via sbt (fpp-sbt -> sbt runMain generateCppDoc), but native-build.yml ran ./test without sbt on PATH, failing on the manylinux container with 'sbt: command not found'. Reuse the existing setup-sbt action (already used in build-scala-native.yml; covers macOS + manylinux) before both ./test invocations. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
With sbt installed, the CppWriter lib test still failed: 'sbt: line 481: java: command not found'. The native-image job only exports GraalVM as FPP_GRAALVM_JAVA_HOME; sbt resolves java via JAVA_HOME. Add setup-java (temurin 17, as build-scala-native.yml does) after the native-image build so it doesn't shadow GraalVM during that step. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Lex-ari
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What if your
fpp-to-jsoncall didn't eat all the ram in the world