Skip to content

docs: require versioned stamp metadata on stamped invoices #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
javorosas merged 2 commits into from
Oct 30, 2026
Merged

docs: require versioned stamp metadata on stamped invoices #318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ab173a
docs: require versioned metadata on stamped invoice responses
javorosas Oct 28, 2026
1d3a27e
Merge remote-tracking branch 'origin/main' into docs/required-stamped…
javorosas Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion website/openapi_v2.en.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13701,7 +13701,22 @@ components:
complement_string:
type: string
description: Original string of the fiscal stamp.
required: [date, sat_signature, sat_cert_number, signature, complement_string]
required: [version, date, sat_signature, sat_cert_number, signature, complement_string]
oneOf:
- type: object
required: [version]
properties:
version:
type: string
enum: ['1.0']
Comment thread
javorosas marked this conversation as resolved.
Resolved
- type: object
required: [version, rfc_provider_cert]
properties:
version:
type: string
enum: ['1.1']
rfc_provider_cert:
type: string
StampProperties:
type: object
description: Information about the digital stamp added by the PAC.
Expand Down
17 changes: 16 additions & 1 deletion website/openapi_v2.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13653,7 +13653,22 @@ components:
complement_string:
type: string
description: Cadena original del timbre fiscal digital.
required: [date, sat_signature, sat_cert_number, signature, complement_string]
required: [version, date, sat_signature, sat_cert_number, signature, complement_string]
oneOf:
- type: object
required: [version]
properties:
version:
type: string
enum: ['1.0']
Comment thread
javorosas marked this conversation as resolved.
Resolved
- type: object
required: [version, rfc_provider_cert]
properties:
version:
type: string
enum: ['1.1']
rfc_provider_cert:
type: string
StampProperties:
type: object
description: Información sobre el timbre fiscal digital agregado por el PAC.
Expand Down
6 changes: 5 additions & 1 deletion website/test/openapi-types.fixture.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ const createdInvoiceStamp: components["schemas"]["Stamp"] | null | undefined = c
void createdInvoiceDate;
void createdInvoiceStamp;
if (createdInvoiceResponse.status === 'valid' || createdInvoiceResponse.status === 'canceled') {
const stampedFields: [string, string, string, string, string, string, string | undefined, string | undefined] = [
const stampedFields: [string, string, string, string, string, string, string, string | undefined] = [
createdInvoiceResponse.uuid,
createdInvoiceResponse.stamp.date,
createdInvoiceResponse.stamp.signature,
Expand All @@ -178,6 +178,10 @@ if (createdInvoiceResponse.status === 'valid' || createdInvoiceResponse.status =
createdInvoiceResponse.stamp.legend,
];
void stampedFields;
if (createdInvoiceResponse.stamp.version === '1.1') {
const certifierRfc: string = createdInvoiceResponse.stamp.rfc_provider_cert;
void certifierRfc;
}
}

// A payment summary can be reused directly in a payment complement.
Expand Down
Loading