Repository navigation
build(deps-dev): move to vitest 5, the Workers plugin and canonicalize 5 - #70
Merged
Merged
Conversation
vitest and @vitest/coverage-v8 go to 5.0.3 in every package, so trilean no longer lags the other two on 4.x. @cloudflare/vitest-pool-workers 0.22 peers on vitest 4 and is deprecated in favour of @cloudflare/vitest-plugin, which accepts vitest 5 and exports the same cloudflareTest plugin, so the workers project swaps its import. canonicalize 5.1.0 only changes output for values with no JSON form (undefined properties, sparse arrays, boxed primitives), none of which the generated JSON Schema contains.
Mearman
marked this pull request as ready for review
October 10, 2026 10:43
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🎉 This PR is included in trilean-regex@1.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in trilean@1.7.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in trilean-sql@2.2.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #58 and #59, which fail on an outdated lockfile because Dependabot did not update
pnpm-lock.yaml. Refs #58, refs #59.#58 alone could not work:
@vitest/coverage-v85 needs vitest 5, and@cloudflare/vitest-pool-workers0.22 peers on vitest 4 and is deprecated. The workers project now uses its successor@cloudflare/vitest-plugin, which takes vitest 5 and exports the samecloudflareTest. vitest and coverage-v8 are 5.0.3 in all three packages; canonicalize is 5.1.0.canonicalize 5 changes output only for undefined properties, sparse arrays and boxed primitives. I built the schema generator against 4.0.0 and 5.1.0 on the same source and
trilean.schema.jsonis byte-identical. It also needs Node 22; it is a dev dependency and.tool-versionsis already 22.Lint, typecheck, coverage, integration, smoke and workers all pass locally via the root scripts.