Skip to content

Don't send keepalive until the client acknowledges FinishedUpdate #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KamikotoTkach wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't send keepalive until the client acknowledges FinishedUpdate #281

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions plugin/src/main/java/net/elytrium/limboapi/server/LimboSessionHandlerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,13 @@ public void onConfig(LimboPlayer player) {
return;
}

// FinishedUpdate is already sent, but the client hasn't acknowledged it yet. Vanilla clients answer
// a keepalive received in this window while their outbound protocol is unconfigured and disconnect with
// "Pipeline has no outbound protocol configured", so wait for the acknowledgement like vanilla servers do.
if (!this.playTransition.isDone()) {
return;
}

if (this.keepAlivePending) {
if (++this.keepAlivesSkipped == 2) {
connection.closeWith(this.plugin.getPackets().getTimeOut(this.player.getConnection().getState()));
Expand Down