Repository navigation
fix(site): keep site credentials out of the log - #118
Merged
Merged
Conversation
The database and database root passwords are registered with EE::obfuscate() when core provides it, and 'ee site info --format=json' prints the site row without writing it to the log.
The logs directory is now created readable by root only, so the log output step reads it with sudo.
There was a problem hiding this comment.
🟡 Changes recommended
The credential-protection paths need regression tests proving secrets remain absent from logs.
1 open finding
What changed in this PR
Prevents PHP site database credentials from being written to logs and restores CI log visibility.
Changes:
- Registers database credentials for masking.
- Sends JSON site information only to stdout.
- Reads protected CI logs with
sudo.
| File | Description |
|---|---|
src/PHP.php |
Protects credentials from file logging. |
.github/workflows/test_and_build.yml |
Reads root-protected logs in CI. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated or given database password is registered for masking (when core provides it) and
site info --format=jsonno longer writes to the log. CI reads the logs with sudo.