Skip to content

fix(clone): mask the other site's credentials in logged clone and sync commands - #511

Merged
mrrobot47 merged 1 commit into
EasyEngine:developfrom
mrrobot47:fix/mask-clone-credentials
Oct 12, 2026
Merged

mrrobot47 merged 1 commit into
EasyEngine:developfrom
mrrobot47:fix/mask-clone-credentials

Conversation

@mrrobot47

Copy link
Copy Markdown
Member

The site details read from the other side of a clone or sync are registered for masking (when core provides it), so their credentials don't appear in the logged clone and sync commands.

…c commands

The site details read from the source or destination (ee site info --format=json) hold its database and admin passwords, which go into the database copy commands. They are now registered with EE::obfuscate() when core provides it.
@mrrobot47
mrrobot47 requested a balanced review from Copilot October 12, 2026 09:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The compatibility-guarded change correctly masks relevant credentials without affecting older cores.

0 open findings

🧠 Review effort: Balanced

@mrrobot47
mrrobot47 merged commit 0c40e5d into EasyEngine:develop Oct 12, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants