Repository navigation
Conversation
…ed 'ccpp_scheme_utils.F90'.
jimmielin
approved these changes
Oct 5, 2026
jimmielin
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @nusbaume! Just a few notes that didn't fit in particular locations:
- This changes several schemes (HB, UW, ...) to remove
const_props, so a CAM update is needed - If a CAM update is made, the lookup might need to be updated to be case-insensitive, and also return errcode=0 with int_unassigned instead of
errcode=1when not found (this might crash a good amount of CCPP schemes)
Collaborator
Author
|
Great catch @jimmielin! I've made ESCOMP/CAM#1711 to implement the needed CAM-side changes. |
Collaborator
|
merged as part of #433 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tag name (The PR title should also include the tag name):
Originator(s): nusbaume (with actual code mods coming from Claude Opus-5.5)
Description (include issue title and the keyword ['closes', 'fixes', 'resolves'] and issue number):
This PR replaces the use of the locally-provided
ccpp_const_get_idxwith the CCPP-framework providedccpp_constituent_indexsubroutine, and removes the no-longer-neededccpp_const_utils.F90. Beyond just code clean-up, this switch provides two major advantages:ccpp_constituent_indexFixes #215
Addresses #137
List all namelist files that were added or changed: N/A
List all files eliminated and why:
List all files added and what they do:
List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status main...<your_branch_name>)List all automated tests that failed, as well as an explanation for why they weren't fixed:
Is this an answer-changing PR? If so, is it a new physics package, algorithm change, tuning change, etc?
No, this PR will not change answers.
If yes to the above question, describe how this code was validated with the new/modified features: