Repository navigation
Allow diag_table changes via user_nl_mom, and fix user_nl_mom/MOM_override bugs - #353
Open
alperaltuntas wants to merge 12 commits into
Open
alperaltuntas wants to merge 12 commits into
alperaltuntas wants to merge 12 commits into
Conversation
…concatenation in error messages
…s when reading MOM_input-style files
… as MOM6 reads them
…eMods conflicts with expect
…le files, as MOM6 does
…OM_input (and so MOM6) expects it
…free param_file_reader.read_MOM_params
… diag_table streams
alperaltuntas
requested review from
gustavo-marques,
manishvenu and
mnlevy1981
October 7, 2026 18:37
Collaborator
|
@AidanJanney, this PR might be of interest to you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow changing the diag_table via user_nl_mom, and fix several bugs in how user_nl_mom is read and turned into MOM_override.
diag_table changes are given as
diag_table%<stream>%<key> <operator> <value>, e.g.:user_nl_mom and MOM_override:
KPP%N_SMOOTH = 2.!,//,/* */).#overrideinstead of(UNCHANGED).Other fixes:
WAVE_METHOD = "SURFACE_BANDS"), andT/.true.are recognized (USE_MARBL_TRACERS = Tused to skip marbl_in).None.No answer changes for existing configurations.
Testing: ran buildnml for ~1140 variants (12 compsets/grids including MARBL, WW3 and B; all OCN_DIAG_MODE/TEST/sections combinations; run types; multi-instance; SourceMods; testmods; user_nl_mom edge cases) and compared the generated input files against main: they differ only where intended. aux_mom is currently being run.
Co-authored by claude.