Repository navigation
Conversation
mkavulich
requested review from
MarekWlasak,
cacraigucar,
climbfuji,
dustinswales,
grantfirl,
nusbaume,
peverwhee,
ss421 and
svahl991
as code owners
October 8, 2026 19:15
climbfuji
approved these changes
Oct 8, 2026
| sec_comment = '' | ||
| sec_comment = re.sub(' +', ' ', sec_comment) | ||
| for line in sec_comment.split('\\n'): | ||
| snl.write(f'{line.strip()}\n') |
Collaborator
There was a problem hiding this comment.
Thanks for replacing all this gibberish with something that is actually readable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I recently noticed that the Metadata files do not contain the comments for individual standard name entries. This PR fixes that issue by adding the appropriate logic to tools/write_standard_name_table.py
Issues
Resolves #158