Skip to content

Skip CUDA installation step if already installed - #325

Merged
ocaisa merged 3 commits into
EESSI:mainfrom
Flamefire:patch-4
Oct 28, 2026
Merged

Skip CUDA installation step if already installed#325
ocaisa merged 3 commits into
EESSI:mainfrom
Flamefire:patch-4

Conversation

@Flamefire

@Flamefire Flamefire commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Check the number of packages and skip the whole disk-space calculation and installation step.

This also avoids failures due to insufficient disk space that is not actually required.
In my case I only have 10GB left but the space checks for 5GB "required" times 3 (for safety) and errors out even if I have already installed everything

Note that the most of the change is an indent, so hide whitespace change for review

@Flamefire
Skip CUDA installation step if already installed
09f095e 
Check the number of packages and skip the whole disk-space calculation and installation step.

This also avoids failures due to insufficient disk space that is not actually required.
ocaisa
ocaisa approved these changes Oct 28, 2026
View reviewed changes

@ocaisa ocaisa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I dread having to actually test this

ocaisa
ocaisa requested changes Oct 28, 2026
View reviewed changes
Comment thread scripts/gpu_support/nvidia/install_cuda_and_libraries.sh Resolved
@Flamefire @ocaisa
Add process easystack file even if no work needed to be done
95bdb6d 
Co-authored-by: ocaisa <alan.ocais@cecam.org>
ocaisa
ocaisa approved these changes Oct 28, 2026
View reviewed changes

@ocaisa ocaisa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocaisa

ocaisa commented Oct 28, 2026

Copy link
Copy Markdown
Member

bot: build repo:eessi.io-2023.06-software instance:eessi-bot-deucalion for:arch=aarch64/a64fx
bot: build repo:eessi.io-2025.06-software instance:eessi-bot-deucalion for:arch=aarch64/a64fx
bot: build repo:eessi.io-2026.06-software instance:eessi-bot-deucalion for:arch=aarch64/a64fx

@eessi-bot-deucalion

eessi-bot-deucalion Bot commented Oct 28, 2026 •
edited
Loading

Copy link
Copy Markdown

New job on instance eessi-bot-deucalion for repository eessi.io-2023.06-software
Building on: a64fx
Building for: aarch64/a64fx
Job dir: /home/eessibot/new-bot/jobs/2026.10/pr_325/2157954

date job status comment
Oct 28 13:48:19 UTC 2026 submitted job id 2157954 awaits release by job manager
Oct 28 13:48:58 UTC 2026 released job awaits launch by Slurm scheduler
Oct 28 13:50:09 UTC 2026 running job 2157954 is running
Oct 28 13:52:47 UTC 2026 finished
😁 SUCCESS (click triangle for details)
Details
✅ job output file slurm-2157954.out
✅ no message matching FATAL:
✅ no message matching ERROR:
✅ no message matching FAILED:
✅ no message matching required modules missing:
✅ found message(s) matching No missing installations
✅ found message matching .tar.* created!
Artefacts
eessi-2023.06-software-linux-aarch64-a64fx-17931955190.tar.zstsize: 0 MiB (5120 bytes)
entries: 1
modules under 2023.06/software/linux/aarch64/a64fx/modules/all
no module files in tarball
software under 2023.06/software/linux/aarch64/a64fx/software
no software packages in tarball
reprod directories under 2023.06/software/linux/aarch64/a64fx/reprod
no reprod directories in tarball
other under 2023.06/software/linux/aarch64/a64fx
no other files in tarball
Oct 28 13:52:47 UTC 2026 test result
😢 FAILURE (click triangle for details)
Reason
EESSI test suite was not run, test step itself failed to execute.
Details
✅ job output file slurm-2157954.out
❌ found message matching ERROR:
✅ no message matching [\s*FAILED\s*].*Ran .* test case
Oct 28 14:00:37 UTC 2026 uploaded transfer of eessi-2023.06-software-linux-aarch64-a64fx-17931955190.tar.zst to S3 bucket succeeded

@eessi-bot-deucalion

eessi-bot-deucalion Bot commented Oct 28, 2026 •
edited
Loading

Copy link
Copy Markdown

New job on instance eessi-bot-deucalion for repository eessi.io-2025.06-software
Building on: a64fx
Building for: aarch64/a64fx
Job dir: /home/eessibot/new-bot/jobs/2026.10/pr_325/2157957

date job status comment
Oct 28 13:48:26 UTC 2026 submitted job id 2157957 awaits release by job manager
Oct 28 13:48:55 UTC 2026 released job awaits launch by Slurm scheduler
Oct 28 13:50:12 UTC 2026 running job 2157957 is running
Oct 28 13:52:50 UTC 2026 finished
😁 SUCCESS (click triangle for details)
Details
✅ job output file slurm-2157957.out
✅ no message matching FATAL:
✅ no message matching ERROR:
✅ no message matching FAILED:
✅ no message matching required modules missing:
✅ found message(s) matching No missing installations
✅ found message matching .tar.* created!
Artefacts
eessi-2025.06-software-linux-aarch64-a64fx-17931955110.tar.zstsize: 0 MiB (5118 bytes)
entries: 1
modules under 2025.06/software/linux/aarch64/a64fx/modules/all
no module files in tarball
software under 2025.06/software/linux/aarch64/a64fx/software
no software packages in tarball
reprod directories under 2025.06/software/linux/aarch64/a64fx/reprod
no reprod directories in tarball
other under 2025.06/software/linux/aarch64/a64fx
no other files in tarball
Oct 28 13:52:50 UTC 2026 test result
😢 FAILURE (click triangle for details)
Reason
EESSI test suite was not run, test step itself failed to execute.
Details
✅ job output file slurm-2157957.out
❌ found message matching ERROR:
✅ no message matching [\s*FAILED\s*].*Ran .* test case
Oct 28 14:00:58 UTC 2026 uploaded transfer of eessi-2025.06-software-linux-aarch64-a64fx-17931955110.tar.zst to S3 bucket succeeded

@eessi-bot-deucalion

eessi-bot-deucalion Bot commented Oct 28, 2026 •
edited
Loading

Copy link
Copy Markdown

New job on instance eessi-bot-deucalion for repository eessi.io-2026.06-software
Building on: a64fx
Building for: aarch64/a64fx
Job dir: /home/eessibot/new-bot/jobs/2026.10/pr_325/2157961

date job status comment
Oct 28 13:48:32 UTC 2026 submitted job id 2157961 awaits release by job manager
Oct 28 13:48:52 UTC 2026 released job awaits launch by Slurm scheduler
Oct 28 13:50:15 UTC 2026 running job 2157961 is running
Oct 28 13:56:17 UTC 2026 finished
😁 SUCCESS (click triangle for details)
Details
✅ job output file slurm-2157961.out
✅ no message matching FATAL:
✅ no message matching ERROR:
✅ no message matching FAILED:
✅ no message matching required modules missing:
✅ found message(s) matching No missing installations
✅ found message matching .tar.* created!
Artefacts
eessi-2026.06-software-linux-aarch64-a64fx-17931955290.tar.zstsize: 0 MiB (5117 bytes)
entries: 1
modules under 2026.06/software/linux/aarch64/a64fx/modules/all
no module files in tarball
software under 2026.06/software/linux/aarch64/a64fx/software
no software packages in tarball
reprod directories under 2026.06/software/linux/aarch64/a64fx/reprod
no reprod directories in tarball
other under 2026.06/software/linux/aarch64/a64fx
no other files in tarball
Oct 28 13:56:17 UTC 2026 test result
😁 SUCCESS (click triangle for details)
ReFrame Summary
[ PASSED ] Ran 0/0 test case(s) from 0 check(s) (0 failure(s), 0 expected failure(s), 0 skipped, 0 aborted)
Details
✅ job output file slurm-2157961.out
✅ no message matching ERROR:
✅ no message matching [\s*FAILED\s*].*Ran .* test case
Oct 28 14:00:49 UTC 2026 uploaded transfer of eessi-2026.06-software-linux-aarch64-a64fx-17931955290.tar.zst to S3 bucket succeeded

@ocaisa

ocaisa commented Oct 28, 2026

Copy link
Copy Markdown
Member

Staging PR merged, should be ingested soon.

Thanks for the contribution @Flamefire

@ocaisa
ocaisa merged commit a5bf45e into EESSI:main Oct 28, 2026
91 checks passed
@Flamefire
Flamefire deleted the patch-4 branch October 28, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocaisa ocaisa ocaisa approved these changes

Assignees

No one assigned

Labels

bot:deploy

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Flamefire @ocaisa