Repository navigation
Defer body mapping reports until matching SAA signals are processed - #2858
Open
CMDR-Evolution wants to merge 1 commit into
Open
CMDR-Evolution wants to merge 1 commit into
CMDR-Evolution wants to merge 1 commit into
Conversation
Keep core mapping state immediate and release the mapping notification after matching SAA signals or a one-second fallback. Cover separate journal reads, body identity, replay, rings, context changes, and timer races with focused tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Elite’s journal records SAAScanComplete and SAASignalsFound in that order, with the same timestamp. A detailed Scan follows. EDDI creates Body mapped from SAAScanComplete and Surface signals detected from SAASignalsFound.
In EDDI 5.0.5, Body mapped runs before Surface signals detected has supplied the biological genera. My personality therefore keeps its biological report separate from Body report. Previously, I was able to include that information in the mapping report.
A fresh journal example from 22 October is Piscium Sector PI-T b3-1 2 a (system address 2869440619937, body ID 4):
20:33:00 UTC — SAAScanComplete
20:33:00 UTC — SAASignalsFound, including Bacterium and Fonticulua
20:33:01 UTC — detailed Scan
This change updates the mapped-body state immediately, but waits to deliver the Body mapped notification until matching SAA signals have been processed. It matches by system address and body ID, including across separate journal reads. If matching signals do not arrive within one second, it releases the mapping notification as a fallback.
I would appreciate any suggestions if there is a better way to make the genera available to a body mapping report.
Validation: where the existing ordering regression fails on the unchanged pipeline., with this change: 15 focused tests pass in an isolated harness that compiles the production event pipeline.