Skip to content

Document passkey management improvements - #1270

Merged
StuFrankish merged 3 commits into
mainfrom
sf/passkey-samples-and-docs
Oct 21, 2026
Merged

StuFrankish merged 3 commits into
mainfrom
sf/passkey-samples-and-docs

Conversation

@StuFrankish

Copy link
Copy Markdown
Member

Summary

  • Document configurable passkey challenge size, the WebAuthn 16-byte recommendation, and startup validation behavior.
  • Explain transport hints, their known-user authentication flow, and their client-reported, non-authoritative nature.
  • Document signature verifier and attestation format validator extension contracts, registration rules, and configuration behavior.
  • Clarify known-user verification and application-owned second-factor completion/session promotion.
  • Update the User Management configuration reference for challenge size and supported algorithms.

Validation

  • git diff --check
  • npm exec --no -- astro build (passes; existing code-block language warnings remain).

Copilot AI balanced review requested due to automatic review settings October 19, 2026 09:52
@StuFrankish
StuFrankish requested review from a team October 19, 2026 09:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Security-sensitive API contracts and startup-validation guarantees need implementation confirmation before approval.

No open issues 🎉

What changed in this PR

Updates User Management documentation to explain passkey configuration, extensibility, and application responsibilities.

Changes:

  • Documents challenge sizing, startup validation, and algorithm selection.
  • Explains transport hints and signature verifier/attestation validator contracts.
  • Clarifies known-user verification and application-owned second-factor completion.
File Description
astro/​src/​content/​docs/​identityserver/​identity/​user-management/​reference/​configuration.md Updates challenge size and supported algorithm settings.
astro/​src/​content/​docs/​identityserver/​identity/​user-management/​authentication/​passkeys.mdx Expands passkey configuration, extension, and authentication guidance.

Review effort: Balanced

@maartenba maartenba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor things

@maartenba maartenba added the documentation Improvements or additions to documentation label Oct 19, 2026
Copilot AI balanced review requested due to automatic review settings October 19, 2026 10:21
@StuFrankish StuFrankish self-assigned this Oct 19, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The documented API contracts and lifecycle guarantees need human verification against the User Management implementation.

No open issues 🎉

Review effort: Balanced

@maartenba

Copy link
Copy Markdown
Member

@StuFrankish Can you rebase onto main and consider using the versioning support to have switches between vCurrent (8.0) and vNew (8.1)?

maartenba

This comment was marked as resolved.

- Explain challenge length requirements and startup validation
- Document transport hints and passkey extension points
- Clarify known-user verification and second-factor completion
- Explain the signed payload inputs in plain language
- Add a table for common transport hints
- Clarify that pending state does not replace challenge storage
- Gate transport hints and extension sections to 8.1
- Show startup challenge size validation for 8.1 and the previous behavior for 8.0
- Split the PasskeyOptions reference table by version
@StuFrankish
StuFrankish force-pushed the sf/passkey-samples-and-docs branch from c725101 to d7cc9b7 Compare October 21, 2026 14:12
Copilot AI balanced review requested due to automatic review settings October 21, 2026 14:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The documentation changes are consistent with their stated scope, and no blocking issues were identified.

No open issues 🎉

Review effort: Balanced

@StuFrankish
StuFrankish marked this pull request as ready for review October 21, 2026 14:19
@StuFrankish
StuFrankish merged commit cd1cf25 into main Oct 21, 2026
3 checks passed
@StuFrankish
StuFrankish deleted the sf/passkey-samples-and-docs branch October 21, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants