Skip to content

Make dummy PV limit data more realistic - #25

Merged
ptsOSL merged 5 commits into
mainfrom
hla-1168-d2-dummy-limits-data
Oct 1, 2026
Merged

ptsOSL merged 5 commits into
mainfrom
hla-1168-d2-dummy-limits-data

Conversation

@ptsOSL

@ptsOSL ptsOSL commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator
  • Magnet limits are taken from current magnet power supplies spreadsheet
  • I had to modify the QUAD lower limits to allow negative currents even though these power supplies are unipolar. I believe this issue is caused by the polarity of the MML physics values being correct.
  • BPM limits are the same as for D2
  • RF limits were made to vary 20KHz around the ideal theoretical value. For D1 they varied 10KHz around a different ideal theoretical value.
  • The remaining values were set to sensible estimates based on my knowledge of our systems. These values aren't currently important, so it is okay if they are approximate. If they become important later, they may need to be adjusted then.

@codecov

codecov Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 14.28571% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 25.11%. Comparing base (d23dc13) to head (56ac7c4).

Files with missing lines Patch % Lines
src/virtac/create_csv.py 14.28% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
- Coverage   25.30%   25.11%   -0.20%     
==========================================
  Files           5        5              
  Lines         648      661      +13     
==========================================
+ Hits          164      166       +2     
- Misses        484      495      +11     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ptsOSL
ptsOSL force-pushed the hla-1168-d2-dummy-limits-data branch from 46271e8 to 42af451 Compare September 30, 2026 13:46
@ptsOSL
ptsOSL force-pushed the hla-1168-d2-dummy-limits-data branch from 42af451 to 4d65ee1 Compare September 30, 2026 14:08
Previously just the families were being checked, but some pytac
elements have multiple families with valid limits and so sometimes the wrong
limits would be used for the PV. We now check the PV name rather than assuming
it is the correct PV for the family
@ptsOSL
ptsOSL merged commit 6d50298 into main Oct 1, 2026
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants