Make dummy PV limit data more realistic - #25
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
==========================================
- Coverage 25.30% 25.11% -0.20%
==========================================
Files 5 5
Lines 648 661 +13
==========================================
+ Hits 164 166 +2
- Misses 484 495 +11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ptsOSL
force-pushed
the
hla-1168-d2-dummy-limits-data
branch
from
September 30, 2026 13:46
46271e8 to
42af451
Compare
ptsOSL
force-pushed
the
hla-1168-d2-dummy-limits-data
branch
from
September 30, 2026 14:08
42af451 to
4d65ee1
Compare
Previously just the families were being checked, but some pytac elements have multiple families with valid limits and so sometimes the wrong limits would be used for the PV. We now check the PV name rather than assuming it is the correct PV for the family
MichaelStubbings
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.