Repository navigation
fix(studio,data): repair the release review findings in Studio and Get Data - #97
Merged
Merged
Conversation
…t Data Number each chat message's turn from the end of the transcript so forked shares pair replies with their own cards and plans. Keep the "Computed by" credit in More Info, describe each dividing step from its own inputs, settle a failed cite link and log its cause. Let loading cards and text-card gaps drag. Read the members list while membership is unsettled, scroll a heading token clear of the header before its menu opens, and build the download dialog's in-file note from the same flags as its extra columns, with kinds per role.
#96 scrolls a Change's trigger into view before its menu opens, for heading tokens and the Refine button alike, so this branch keeps SlotMenu, the .slot scroll margin and the header height as on dev.
… in the helper The download dialog's extras list and in-file note read one classifier, longLayoutSuffix, so a role's kind columns are never both claimed in the file and offered as extras. messageTurns numbers no turn below 1. citeLinkOnce settles a throwing snapshot as a failed link and logs it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes eight defects in website #90, #91, #92 and #94 before they ship to production with the release.
Changes
messageTurnsinsrc/lib/studio/activityView.tsnumbers each message by turn, aligning the last prompt with the last Activity entry, and counts from 1 when the transcript holds more prompts than that entry's turn.ChatPanel.tsxreads that one numbering for plans,turnWidgets,ChatMessageand the feedback id, so a fork of a card or canvas share shows each reply's own cards and plan. The saved shape is unchanged, so forks already saved read correctly.view.fromis set, so a computed card with no credited source keeps "Computed by the Development Finance Observatory." (CardInfoPanel.tsx).sidesOfindescriptionBlocks.tslabels each dividing step from its own inputs, andcalculationOfreturns a calculation only for a card with exactly one dividing step.citeLinkOnceinsrc/lib/studio/infoPanel.tssettles a snapshot that cannot be built or saved as a failed link, logsStudio: a cite link could not be made, and lets the reader ask again.textInner(data-card-frame) drags while its title and body stay content (cardPress.ts), with the grab cursor over the gaps (Whiteboard.module.scss).maybeOneVariableinsrc/lib/search/view.tsreturns true whileserved_countis null, so the members list is read when the panel opens and a one-variable answer names its variable.longLayoutSuffixinsrc/lib/search/downloadOptions.tsclassifies each enrichment once, as a label, a kind (party_kind,party_class,party_whole) or neither, and both the extra columns list and the in-file note read it. A servedin_long_layoutflag decides; without it,long_layout_defaultsdecides through{column}_labeland{column}_kind, so a role whose kind column is in the file no longer offers Party kind as an extra.inFileNotestates kinds per role, with each role's examples taken from what dfo-apis writes.Notes for reviewers
in_long_layout, so production uses thelong_layout_defaultspath.SlotMenu.tsxalone.served_countis null, opening About this answer reads the members list for any family size, as the panel did before feat(data): tidy the unit picker, About this answer and download dialog #90.motion-kit/render.tsxstill rendersboardStyles.handle, which feat(studio): credit sources on cards and redraw the More Info panel #91 removed; the motion-kit films are left for their own change.Testing:
pnpm lint,pnpm lint:css,pnpm typecheck,pnpm buildandpnpm build:migrate-sharespass.pnpm testruns 2,223 tests; 2,193 pass and the 30 that need a local Postgres fail on authentication, as ondev. New tests for turn numbering, two dividing steps, text-card presses, unsettled membership, the in-file classifier, per-role kinds and a failed cite link each fail without the change.