Skip to content

fix(studio,data): repair the release review findings in Studio and Get Data - #97

Merged
jm-rivera merged 3 commits into
devfrom
fix/release-review-followups
Nov 1, 2026
Merged

jm-rivera merged 3 commits into
devfrom
fix/release-review-followups

Conversation

@jm-rivera

@jm-rivera jm-rivera commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Fixes eight defects in website #90, #91, #92 and #94 before they ship to production with the release.

Changes

  • Activity and chat turns: messageTurns in src/lib/studio/activityView.ts numbers each message by turn, aligning the last prompt with the last Activity entry, and counts from 1 when the transcript holds more prompts than that entry's turn. ChatPanel.tsx reads that one numbering for plans, turnWidgets, ChatMessage and the feedback id, so a fork of a card or canvas share shows each reply's own cards and plan. The saved shape is unchanged, so forks already saved read correctly.
  • More Info: the Sources block renders whenever view.from is set, so a computed card with no credited source keeps "Computed by the Development Finance Observatory." (CardInfoPanel.tsx). sidesOf in descriptionBlocks.ts labels each dividing step from its own inputs, and calculationOf returns a calculation only for a card with exactly one dividing step.
  • Cite link: citeLinkOnce in src/lib/studio/infoPanel.ts settles a snapshot that cannot be built or saved as a failed link, logs Studio: a cite link could not be made, and lets the reader ask again.
  • Card drag: LivePlaceholder's title and skeleton bones are drag handles, and a press on TextCard's bare textInner (data-card-frame) drags while its title and body stay content (cardPress.ts), with the grab cursor over the gaps (Whiteboard.module.scss).
  • About this answer: maybeOneVariable in src/lib/search/view.ts returns true while served_count is null, so the members list is read when the panel opens and a one-variable answer names its variable.
  • Download dialog: longLayoutSuffix in src/lib/search/downloadOptions.ts classifies each enrichment once, as a label, a kind (party_kind, party_class, party_whole) or neither, and both the extra columns list and the in-file note read it. A served in_long_layout flag decides; without it, long_layout_defaults decides through {column}_label and {column}_kind, so a role whose kind column is in the file no longer offers Party kind as an extra. inFileNote states kinds per role, with each role's examples taken from what dfo-apis writes.

Notes for reviewers

Testing: pnpm lint, pnpm lint:css, pnpm typecheck, pnpm build and pnpm build:migrate-shares pass. pnpm test runs 2,223 tests; 2,193 pass and the 30 that need a local Postgres fail on authentication, as on dev. New tests for turn numbering, two dividing steps, text-card presses, unsettled membership, the in-file classifier, per-role kinds and a failed cite link each fail without the change.

…t Data

Number each chat message's turn from the end of the transcript so
forked shares pair replies with their own cards and plans. Keep the
"Computed by" credit in More Info, describe each dividing step from its
own inputs, settle a failed cite link and log its cause. Let loading
cards and text-card gaps drag. Read the members list while membership
is unsettled, scroll a heading token clear of the header before its
menu opens, and build the download dialog's in-file note from the same
flags as its extra columns, with kinds per role.
#96 scrolls a Change's trigger into view before its menu opens, for
heading tokens and the Refine button alike, so this branch keeps
SlotMenu, the .slot scroll margin and the header height as on dev.
… in the helper

The download dialog's extras list and in-file note read one classifier,
longLayoutSuffix, so a role's kind columns are never both claimed in
the file and offered as extras. messageTurns numbers no turn below 1.
citeLinkOnce settles a throwing snapshot as a failed link and logs it.
@jm-rivera
jm-rivera merged commit fad5ba7 into dev Nov 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant