Repository navigation
Conversation
The unit picker drops the standing euro preset, keeps the currency of any country the question names, and puts a "Search N currencies" field first (lib/search/unitPicker.ts, UnitPicker.tsx). About this answer shows each fact once. A fact the search filled in carries its reason and a Change control that opens the same menu the sentence uses (changeTarget in lib/search/refineMenu.ts). Breakdowns list their categories without a variable count, the publisher's own indicator code sits on the Measure row from stat_vars.source_codes, the source appears once, and the citation says "processed by" only when a conversion was applied (lib/search/view.ts, WhyPanel.tsx). The download dialog has one switch for the README, sources and citation files, and folds extra columns under plain names with examples from the answer and blank counts in words. Extra columns the long file already writes are hidden by the API's in_long_layout flag, with the long_layout_defaults comparison as the fallback until the API serves it (lib/search/downloadOptions.ts).
Refine keyed an open role by the role name (`destination:`) while the About rows and the wire use `roleRef` (`where:`), so Change found no Refine entry for an open recipient. Refine now keys roles by `roleRef`.
jm-rivera
marked this pull request as ready for review
October 31, 2026 23:34
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Get Data's unit picker, About this answer panel and download dialog now show each fact once, in words a reader can use, and keep the actions that change the answer next to the facts they change.
Changes
unitPresets,currencySearchLabelinsrc/lib/search/unitPicker.ts;UnitPicker.tsx).buildWhySummaryinsrc/lib/search/view.ts;WhyPanel.tsx).changeTargetinsrc/lib/search/refineMenu.ts;openMenulifted intoDataSearch.tsx).stat_vars.source_codes, and the DFO variable id sits behind a copy control.citationinview.ts).DownloadOptions.tsx,src/lib/search/downloadOptions.ts).in_long_layoutflag (enrichmentAlreadyInFile), with thelong_layout_defaultscomparison as the fallback while the API does not serve it.Notes for reviewers
in_long_layout. The vendored client does not type the field yet, soDatasetEnrichmentwidens it locally insearchClient.ts.onMenuChanges).Testing:
pnpm lint,pnpm lint:css,pnpm typecheck,pnpm test(2,190 pass) andpnpm buildpass. Before and after screenshots against the dev API are below.Screenshots
Before is origin/dev (b91925c) and after is this branch, both against the dev API through a local proxy, at 1440 by 900.