Skip to content

feat: capture library logs - #33

Merged
tillywoodfield merged 1 commit into
devfrom
feat/20-capture-library-logs
Oct 19, 2026
Merged

tillywoodfield merged 1 commit into
devfrom
feat/20-capture-library-logs

Conversation

@tillywoodfield

Copy link
Copy Markdown
Collaborator

What & why

Libraries the pipelines call log through Python's logging, but the Dagster run log only shows what assets write to context.log, so their output never reaches it. This commits the local Dagster instance configuration and has it capture the root logger, so any library whose records propagate shows up in the run log.

Part of #20

Changes

  • Track .dagster_home/dagster.yaml, with python_logs capturing the root logger at INFO. The rest of .dagster_home/ stays ignored.
  • Drop the mkdir .dagster_home setup step from the README, since the directory now comes with the clone.

Notes for reviewers

Checklist

  • Addresses one issue, linked above
  • Tests updated where relevant
  • Docs updated where relevant
  • Self-reviewed the diff

@tillywoodfield

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T15:22:16.276708Z cdb1735 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: cdb1735bb9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@tillywoodfield
tillywoodfield merged commit 02a07ac into dev Oct 19, 2026
2 checks passed
@tillywoodfield
tillywoodfield deleted the feat/20-capture-library-logs branch October 19, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant