Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrites the README and contributing guide for a public reader and moves automation and ingestion settings into
docs/development.md.README.mdnow lists the eight covered datasets, each linking itstransformations.md, and gives a local recipe for World Bank IDS that needs no cloud access. It states that only the*_dc_ingestionassets need ONE'sdev-fin-observatoryproject.CONTRIBUTING.mdgains the code of conduct and security links, says where to raise which kind of issue, and lists the exact CI checks. The automation section, theDCP_*and skills settings that only.env.exampleexplained, the pinneddfo-ontologycommit and a CI summary move todocs/development.md.CONTRIBUTING.mdlinks the organisation code of conduct, security policy and support guide by absolute URL. Those links resolve once DevelopmentFinanceObservatory/.github#1 merges.The README uses
dbt runand notdbt buildfor the local recipe. A singledg launch --assets '*world_bank_ids_dc_export'fails at the dbt step, because cross-dataset dbt tests query schemas of datasets that were never built. Making a one-command local run work is a code change for a separate PR.Testing:
pre-commit run --filespasses on the three files. The World Bank IDS recipe ran end to end and wrote the observation CSVs underdata/processed/world_bank_ids/.