Repository navigation
Conversation
DCP v1.1.6 removes the serving service account's project-wide
secretmanager.secretAccessor role. search_api_gemini_key reads the
Gemini key through that role, so after the upgrade the service would
start without GEMINI_API_KEY and /api/search/* would return 502. A
per-secret grant on "${namespace}-gemini-api-key" keeps the access
under both module versions, and the key script now waits for it.
v1.1.6 also deletes the Cloud Run preprocessing job, which Terraform
cannot do while stateless_deletion_protection is on. Prod turns it off
here, on v1.1.5, so the v1.1.6 apply can complete.
infra/stacks/dcp/main.tf, variables.tf and outputs.tf are upstream's 1.1.6 root files with the module ref pinned to v1.1.6. dcp_version defaults to 1.1.6, which picks the 1.1.6 ingestion images, the ingestion-1.1.6 Dataflow template and the new rollback template. Preprocessing runs as a Cloud Batch job with cpu and memory in milliCPU and MiB, so batch.googleapis.com joins the enabled APIs. The ingestion_prep_job_name output goes, since the Cloud Run preprocessing job no longer exists. The justfile pins CLI 1.1.6. seed-db is removed, init-db drops --init-only, and init-db and migrate-db run under the caller's application default credentials, which need roles/spanner.databaseAdmin and roles/spanner.databaseUser. docs/development.md and the dfo-dev dcp README state the same.
Prod runs Data Commons Platform 1.1.6 and its Cloud Run preprocessing job is gone, so stateless_deletion_protection returns to true.
jm-rivera
force-pushed
the
feat/dcp-v1.1.6
branch
from
October 23, 2026 14:28
a9bf660 to
a1fc36a
Compare
Contributor
Author
|
Prod keeps stateless_deletion_protection on; the 1.1.6 cutover in #61 removes the Cloud Run preprocessing job from state and deletes it with gcloud instead, so there is nothing to restore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets
stateless_deletion_protection = trueagain ininfra/dfo-prod/dcp/dfo.auto.tfvars. Prod turned it off so the Data Commons Platform 1.1.6 apply could delete the Cloud Run preprocessing job. Merge after prod runs 1.1.6 and that job is gone from state.Testing:
terraform fmt -checkon the file. Not applied.