Repository navigation
fix(planner): bind each entity answer to the reading it settles - #87
Merged
Merged
Conversation
Both Congo readings of an entity_name_ambiguous referral offered the same candidates, so a picked node bound to neither entity and a plan could state the other Congo after the user chose one. Search's group candidates posted by a registered name with members were dropped. Each candidate now carries a pick naming its requirement, role, entity and choice. An ask may offer exactly one reading's picks, and submission holds each entity to the user's latest pick for its reading. Members-row group candidates are kept as a name to restate, and an option that joins no one candidate is refused. Co-authored-by: Claude <noreply@anthropic.com>
jm-rivera
marked this pull request as ready for review
October 26, 2026 15:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When “aid from Congo to Congo” produces an entity ambiguity, the donor and recipient offer the same two nodes. Each candidate now carries a pick ID scoped to its requirement and reading. The planner asks about one reading at a time, and submission enforces the user’s latest choice or keeps an unanswered reading unsettled. Choices persist across referrals and are released by free text or an approval-card amendment.
Whole-history copies use their authored requirement’s ID in both displayed picks and ask validation, matching submission’s view of the referral. This keeps a choice made for
debt_historybound todebtacross later referrals.Group candidates requested as members are kept under Search’s registered group name and restated with
memberstrue and nodcid. The join still uses Search’s candidate label, and a shared same-role group name is admitted when either reading accepts it.Testing: 3,534 planner, translator, compiler, and planner-seam tests passed locally, including regressions for history-copy picks, contradictory choices, unanswered and skipped questions, and later referrals to the origin. Repository lint and formatting checks and harness source type checks passed.