Repository navigation
Run the smoke workflows from CI and add a pass/fail check - #1
Merged
Merged
Conversation
johnmaguire
marked this pull request as ready for review
October 21, 2026 15:51
nbrownus
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns smoke-macos and smoke-windows into reusable workflows called from ci.yml instead of triggering on their own, and adds a job that depends on every other job so the Required CI ruleset has one check to require. The smoke jobs are unchanged and manual runs keep their inputs. PRs pass no inputs, so they run exactly as before.