Skip to content

Fix report event counts for repeated simulation identifiers - #185

Merged
francois-drielsma merged 1 commit into
mainfrom
fix/report-entry-event-counts
Oct 22, 2026
Merged

francois-drielsma merged 1 commit into
mainfrom
fix/report-entry-event-counts

Conversation

@francois-drielsma

@francois-drielsma francois-drielsma commented Oct 22, 2026 •

Copy link
Copy Markdown
Member

Description

Prefer (file_index, file_entry_index) for report event counts, then loader index (with file index when available), then complete run/subrun/event identifiers. Preserve CSV-path namespacing so independent job shards remain distinct. A file identifier alone no longer counts as an event identity.

Motivation and Context

Repeated simulation event IDs collapsed 14,240 entries into 40 reported events. This fixes event-count metadata while preserving reconstruction metric accumulation.

Type of Change

  • Bug fix

How Has This Been Tested?

  • Regression tests cover identifier priority and fallbacks, repeated event IDs, multiple files and CSV shards, duplicate object rows across chunks, and report-level confusion counts.
  • Reporting and CLI tests: 73 passed; one unrelated permission test failed because the local filesystem strips the directory setgid bit (independently reproduced with chmod).
  • Regenerated all six report sections from the existing production CSVs: all event-count fields show 14,240. Confusion matrices and histogram counts match exactly; floating-point statistics differ by at most 2.2e-14. No training or inference rerun.
  • All commit hooks passed, including Black, isort and flake8.

Test configuration: macOS, Python 3.13.

Checklist

  • Code follows project style and has been self-reviewed
  • Identity-selection documentation updated
  • Regression tests added
  • CI passes (all 17 GitHub Actions jobs)

@francois-drielsma
francois-drielsma merged commit c342af1 into main Oct 22, 2026
17 checks passed
@codecov

codecov Bot commented Oct 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (31e2212) to head (469eb71).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #185   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          440       440           
  Lines        39331     39336    +5     
=========================================
+ Hits         39331     39336    +5     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/spine/vis/metric/report/base.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant