Skip to content

Add direct LArCV visualization flavor - #3

Merged
francois-drielsma merged 18 commits into
mainfrom
feat/direct-larcv-input
Sep 18, 2026
Merged

francois-drielsma merged 18 commits into
mainfrom
feat/direct-larcv-input

Conversation

@francois-drielsma

@francois-drielsma francois-drielsma commented Sep 17, 2026 •

Copy link
Copy Markdown
Member

Summary

  • detect LArCV ROOT sources and parse them on demand through SPINE 1.2.4
  • discover explicit, dated detector conversion bundles from spine-prod and expose them in the Data panel
  • add a separate ROOT/LArCV-enabled Docker image while keeping the current lean image and tags unchanged
  • publish release tags as latest/version for lean and larcv/version-larcv for the optional flavor
  • preserve converter selection in shared views and document source/config behavior

The image pins the converter commit proposed in DeepLearnPhysics/spine-prod#38. That companion change reuses existing single-detector modifiers for ICARUS and FSD instead of duplicating detector schema knowledge.

Validation

  • 186 tests pass with 100% statement coverage
  • Black, isort, Flake8, pre-commit, actionlint, and strict Sphinx build pass
  • both lean and LArCV Dockerfiles build
  • real fixtures validated through truth-object construction and SPINE scene rendering: 2x2, generic, ND-LAr, FSD, DUNE-HD 10 kt, ProtoDUNE-HD, ProtoDUNE-SP, ProtoDUNE-VD, SBND, and ICARUS single-cryostat
  • final local uncompressed images: 1.37 GB lean, 2.28 GB LArCV

@codecov

codecov Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (3ff28c6) to head (178cb67).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main        #3    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           10        11     +1     
  Lines         1742      1960   +218     
==========================================
+ Hits          1742      1960   +218     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@francois-drielsma
francois-drielsma merged commit b9fb20c into main Sep 18, 2026
8 checks passed
@francois-drielsma
francois-drielsma deleted the feat/direct-larcv-input branch September 18, 2026 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant