Repository navigation
Fix pnpm install trap: migrate lockfile to v9 and pin pnpm 12 - #10
Merged
Merged
Conversation
- Convert frontend/pnpm-lock.yaml from v6 (pnpm 8) to v9 with pnpm 9, keeping every resolved package version unchanged - Pin pnpm 12.11.2 via packageManager in frontend/package.json - Add pnpm-workspace.yaml declaring the es5-ext and protobufjs install scripts as not allowed, so pnpm 12 no longer errors on them - CI: both frontend workflows use pnpm/action-setup@v4 reading packageManager, on Node 22 - README: Node 22 and pnpm 12 prerequisites Refs #7
This was referenced Oct 25, 2026
alessiopagliarulo
approved these changes
Oct 29, 2026
alessiopagliarulo
left a comment
Collaborator
There was a problem hiding this comment.
Thanks Dan, verified: all frontend checks (lint, test, build, prettier) pass on the latest commit. Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix pnpm install trap: migrate lockfile to v9 and pin pnpm 12
GitHub issue number: #7
What user problem are we solving?
frontend/pnpm-lock.yamlwas written by pnpm 8 (lockfile format v6.0). Current pnpm (12.x) can't use a v6 lockfile, so a freshpnpm installre-resolves every dependency and rewrites the lockfile (about 14,000 changed lines). It also stops on two dependency install scripts it hasn't been told about (es5-ext,protobufjs). Every new member hits this on day one. CI also disagreed with itself:node.js.ymlpinned pnpm 8, whilefrontend.ymlinstalled whatever pnpm was newest and then ran--frozen-lockfile.What solution does this PR provide?
packageManager, so local installs and CI all use the same version.Testing Methodology
pnpm install --frozen-lockfilewith nonode_modulessucceeds with no errors or warnings and leaves the lockfile unchanged.pnpm lintandpnpm testboth pass.name@versionentries is identical in the old v6 lockfile and the new v9 lockfile, 1,107 each.Any other considerations
corepack enableonce, or install pnpm 12 globally.ERR_PNPM_INVALID_WORKSPACE_CONFIGURATIONon the newpnpm-workspace.yaml.Closes #7
Assisted-by: Claude Code (Opus 5.5)
Note
Low Risk
Tooling, lockfile format, and CI/doc updates only; no application runtime or security-sensitive logic changes in the shown diff.
Overview
Fixes the fresh
pnpm installtrap where modern pnpm could not use the old v6 lockfile, re-resolved dependencies, and blocked on install scripts fores5-extandprotobufjs.frontend/package.jsonnow pinspnpm@12.11.2viapackageManagerand declaresengines.node>=20. A newpnpm-workspace.yamlsetsallowBuildsfor those two packages so pnpm 12 can install without prompting. The lockfile is upgraded to format v9 (same resolved package set as before, per the PR intent).GitHub Actions (
frontend.yml,node.js.yml) standardize on Node 22.x andpnpm/action-setup@v4, reading the pinned version fromfrontend/package.jsoninstead of mixing globalnpm install -g pnpmand a hardcoded pnpm 8 pin.README.mdprerequisites match (Node 22 LTS, Corepack + pinned pnpm)..github/Architecture.mdis a documentation tree reorder only.Reviewed by Cursor Bugbot for commit f98d655. Bugbot is set up for automated code reviews on this repo. Configure here.