Skip to content

fix(integration-tests): fail the Python build when pip fails #1468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lym953 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(integration-tests): fail the Python build when pip fails #1468

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b46919
fix(integration-tests): fail the Python build when pip fails
lym953 Oct 28, 2026
86e7aef
Merge branch 'main' into yiming.luo/build-python-fail-on-pip-error
lym953 Nov 2, 2026
72f39db
fix(integration-tests): name the docker run step in the build failure…
lym953 Nov 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion integration-tests/scripts/build-python.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,18 @@ build_python_lambda() {
# Install dependencies with Docker using ARM64 platform
# Use the same image that CDK would use for consistency
# Mount pip cache for faster package downloads
# set -e is off inside a function that an if condition calls, so check
# the exit status. The package/ check below cannot see
# a pip failure, because it runs after the .py files are copied in.
docker run --rm --platform linux/arm64 \
-v "$LAMBDA_DIR":/workspace \
-v "$PIP_CACHE_DIR":/root/.cache/pip \
-w /workspace \
public.ecr.aws/sam/build-python3.12 \
pip install -r requirements.txt -t package/
pip install -r requirements.txt -t package/ || {
echo "✗ Build failed: docker run ... pip install exited with status $?"
return 1
}

# Copy source files to package directory
cp -r "$LAMBDA_DIR"/*.py "$LAMBDA_DIR/package/" 2>/dev/null || true
Expand Down
Loading