Repository navigation
[SVLS-9963] chore(bottlecap): upgrade libddwaf, zstd, and serverless-components #1467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -60,7 +60,7 @@ rand = { version = "0.8", default-features = false } | |
| prost = { version = "0.14", default-features = false } | ||
| tonic = { version = "0.14", features = ["transport", "codegen", "server", "channel", "router"], default-features = false } | ||
| tonic-types = { version = "0.14", default-features = false } | ||
| zstd = { version = "0.13.3", default-features = false } | ||
| zstd = { version = "0.14.3", default-features = false } | ||
| futures = { version = "0.3.31", default-features = false } | ||
| serde-aux = { version = "4.7", default-features = false } | ||
| serde_html_form = { version = "0.2", default-features = false } | ||
|
|
@@ -84,22 +84,23 @@ indexmap = {version = "2.11.0", default-features = false} | |
| # be found in the clippy.toml file adjacent to this Cargo.toml. | ||
| datadog-protos = { version = "0.1.0", default-features = false, git = "https://github.com/DataDog/saluki/", rev = "f863626dbfe3c59bb390985fa6530b0621c2a0a2"} | ||
| ddsketch-agent = { version = "0.1.0", default-features = false, git = "https://github.com/DataDog/saluki/", rev = "f863626dbfe3c59bb390985fa6530b0621c2a0a2"} | ||
| # These are pinned to the same crates.io versions that dd-trace-rs's datadog-opentelemetry | ||
| # depends on, so cargo unifies them instead of compiling duplicate copies. Re-check with | ||
| # `cargo tree --duplicates | grep ^libdd-` when bumping either side. | ||
| libdd-capabilities = "3.0.0" | ||
| libdd-common = { version = "5.2.0", default-features = false } | ||
| libdd-trace-protobuf = "4.0.1" | ||
| libdd-trace-utils = { version = "10.1.0", default-features = false, features = ["mini_agent"] } | ||
| libdd-trace-normalization = "3.0.1" | ||
| libdd-trace-obfuscation = { version = "6.0.0", default-features = false } | ||
| libdd-trace-stats = { version = "7.0.0", default-features = false } | ||
| datadog-opentelemetry = { version = "0.5.2", default-features = false, features = ["_unstable_propagation"] } | ||
| dogstatsd = { git = "https://github.com/DataDog/serverless-components", rev = "5859602d609405a9de4d32638673a643caf37534", default-features = false } | ||
| datadog-fips = { git = "https://github.com/DataDog/serverless-components", rev = "5859602d609405a9de4d32638673a643caf37534", default-features = false } | ||
| datadog-agent-config = { git = "https://github.com/DataDog/serverless-components", rev = "5859602d609405a9de4d32638673a643caf37534", default-features = false } | ||
| datadog-agent-trace-sampler = { git = "https://github.com/DataDog/serverless-components", rev = "5859602d609405a9de4d32638673a643caf37534", default-features = false } | ||
| libddwaf = { version = "1.28.1", git = "https://github.com/DataDog/libddwaf-rust", rev = "d1534a158d976bd4f747bf9fcc58e0712d2d17fc", default-features = false, features = ["serde"] } | ||
| # Pin the libdd crates used by Bottlecap's trace pipeline to the release line | ||
| # required by serverless-components PR #196. | ||
| libdd-capabilities = "4.0.1" | ||
| libdd-common = { version = "10.0.0", default-features = false } | ||
| libdd-trace-protobuf = "5.1.1" | ||
| libdd-trace-utils = { version = "16.0.0", default-features = false, features = ["mini_agent"] } | ||
|
Comment on lines
+91
to
+92
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Align Useful? React with 👍 / 👎.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Acked |
||
| libdd-trace-normalization = "4.3.1" | ||
| libdd-trace-obfuscation = { version = "12.0.0", default-features = false } | ||
| libdd-trace-stats = { version = "13.0.0", default-features = false } | ||
| datadog-opentelemetry = { version = "0.6.0", default-features = false, features = ["_unstable_propagation"] } | ||
| dogstatsd = { git = "https://github.com/DataDog/serverless-components", rev = "e462105e918904e6b1ad2ebc153ae561cebe5a34", default-features = false } | ||
|
Comment on lines
+96
to
+97
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Update the PR overview before merging: it says this change pins serverless-components to AGENTS.md reference: AGENTS.md:L22-L23 Useful? React with 👍 / 👎.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Acked |
||
| datadog-fips = { git = "https://github.com/DataDog/serverless-components", rev = "e462105e918904e6b1ad2ebc153ae561cebe5a34", default-features = false } | ||
| datadog-agent-config = { git = "https://github.com/DataDog/serverless-components", rev = "e462105e918904e6b1ad2ebc153ae561cebe5a34", default-features = false } | ||
| datadog-agent-trace-sampler = { git = "https://github.com/DataDog/serverless-components", rev = "e462105e918904e6b1ad2ebc153ae561cebe5a34", default-features = false } | ||
| libddwaf = { version = "2.1.0", git = "https://github.com/DataDog/libddwaf-rust", rev = "bbada5255bf8e9105c06b03ce6d5d63a7c337e2a", default-features = false, features = ["serde"] } | ||
| # Enables the crypto provider libddwaf-sys needs to download prebuilt WAF binaries. | ||
| libddwaf-sys = { version = "2.1.0", git = "https://github.com/DataDog/libddwaf-rust", rev = "bbada5255bf8e9105c06b03ce6d5d63a7c337e2a", default-features = false, features = ["aws-lc-rs"] } | ||
|
|
||
| [dev-dependencies] | ||
| figment = { version = "0.10", default-features = false, features = ["yaml", "env", "test"] } | ||
|
|
||
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the zstd-related entries for
RUSTSEC-2026-0391,RUSTSEC-2026-0398, andRUSTSEC-2026-0403frombottlecap/deny.tomlas part of this upgrade. The comments atdeny.toml:49-52explicitly say the new zstd 0.14/zstd-safe 8.2 dependency line fixes these advisories and that the ignores should be dropped with the bump; leaving them active means a future dependency resolution that reintroduces an affected zstd version will still be silently accepted by the cargo-deny audit.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Acked